search

pkg / errors

Simple error handling primitives
https://godoc.org/github.com/pkg/errors
BSD 2-Clause "Simplified" License
8.18k stars 691 forks source link

travis.yml: add Go 1.13 #212

Closed aperezg closed 4 years ago

aperezg commented 4 years ago

Also deprecate Go 1.10

puellanivis commented 4 years ago

The previous PR to change version information in travis is: PR-200 which is simply titled, “travis.yml: add Go 1.12”

I don’t think it’s necessary to go into why 1.10 support is being dropped, it’s a natural part of upgrading to covering 1.13.

Next up, do things actually break such that we need GO111MODULE=off or is this simply a ”since there is no go.mod file, I’m assuming I have to turn off GO111MODULE”? If it does not actually break things to no specify it, then I see no good reason to change it now.

aperezg commented 4 years ago

Thanks for your comments @puellanivis, they seem very reasonable to me so, I will do the changes that you're proposing me