search

pkg / profile

Simple profiling for Go
BSD 2-Clause "Simplified" License
1.99k stars 124 forks source link

Bug: Interrupt Stop: Race fix during Interrupt. #18

Closed hackintoshrao closed 8 years ago

hackintoshrao commented 8 years ago

The issue is described here https://github.com/minio/minio/issues/1617 . The proposed fix solves the issue.

davecheney commented 8 years ago

Thank you for this PR, I will review it shortly.

This may be invalid, profiling and the race detector will give unreliable results.

davecheney commented 8 years ago

This should be fixed by removing the ability to run the profiler twice per program execution, see c78aac22bd43883fd2817833b982153dcac17b3b

hackintoshrao commented 8 years ago

Thank you @davecheney

davecheney commented 8 years ago

Thanks. Please let me know if it fixes the issue. Please feel free to open another issue if the problem persists.

On Wed, 18 May 2016, 18:58 karthic rao, notifications@github.com wrote:

Thank you @davecheney https://github.com/davecheney

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/pkg/profile/pull/18#issuecomment-219966521

hackintoshrao commented 8 years ago

@davecheney : This fixes the issue. Thank you.