Versioning and breaking change in `MemProfile{Heap,Allocs}` signatures

pkg / profile

Simple profiling for Go

BSD 2-Clause "Simplified" License

1.99k stars 124 forks source link

Versioning and breaking change in `MemProfile{Heap,Allocs}` signatures #59

Closed mmcloughlin closed 3 years ago

mmcloughlin commented 3 years ago

Commit 3704c8d23324a3fc0771ad2c1cef0aa4e9459f6f changed the signatures of MemProfile{Heap,Allocs}. Is this going to require a v2?

davecheney commented 3 years ago

If it did, i'm sorry, but I'm not going to do the v2 nonsense. Sorry.

mmcloughlin commented 3 years ago

Not a problem, I was just curious how you intended to handle it.

davecheney commented 3 years ago

Thanks for catching it. It’s hard to remember back a year but if I did spot the comparison break, which I probably didn’t, I would have said “nah, not worth v2”. This is probably still true.

mmcloughlin commented 3 years ago

Yeah I think you're fine. I assume very few are affected and the fix is removing parens (). But you'd minimize the impact by tagging v1.6.0 now.