search

pkg / rock

Create semantic version tags for your Go packages, search and discover new packages
Apache License 2.0
50 stars 8 forks source link

Doesn't discover existing tags if refs have been packed #3

Closed necrophonic closed 6 years ago

necrophonic commented 7 years ago

If a repository has had it's tags packed with git pack-refs then rock tags returns nothing (and attempting to create a tag assumes current tag is 0.0.0)

Appears to be an issue with gogits/gitlibrary (Known issue - Have opened a pull request to attempt to fix the issue)

Issue: https://github.com/gogits/git/issues/27 PR: https://github.com/gogits/git/pull/31

bketelsen commented 7 years ago

nice. Ping here when the issue is merged and i'll update dependency.

necrophonic commented 6 years ago

Original pull request to https://github.com/gogits/git has no been reviewed and appears the package is no longer actively maintained? Have addressed this issue (and #4?) in PR #8 by proposing switching to use code.gitea.io/git which is still being updated and correctly handles packed refs.

necrophonic commented 6 years ago

Update: After posting the above and pr #8, my original pr https://github.com/gogits/git/pull/31 has been merged.

Should mean this issue can be closed by either updating the gogits/git dependency or using PR #8 to switch to using code.gitea.io/git.