search

pkg / sftp

SFTP support for the go.crypto/ssh package
BSD 2-Clause "Simplified" License
1.52k stars 380 forks source link

Export RealPath for potential client use #410

Closed puellanivis closed 3 years ago

puellanivis commented 3 years ago

Real simple, it’s exactly what the title says, nothing more.

puellanivis commented 3 years ago

As mentioned I went through the path handling code. It’s all generally server-side stuff. Nothing necessary to be done on the client side.

The standard even says this request packet can be called with essentially any arbitrary path.

drakkan commented 3 years ago

Great! I suggest to add a comment to avoid warnings like this one exported method Client.RealPath should have comment or be unexported.

drakkan commented 3 years ago

server side the method just calls cleanPacketPath so specific test cases should not be needed

puellanivis commented 3 years ago

Feel free to merge, and then cut a release at your leisure.