search

pkg / sftp

SFTP support for the go.crypto/ssh package
BSD 2-Clause "Simplified" License
1.5k stars 380 forks source link

Simplify ReadDir #460

Closed codesoap closed 3 years ago

codesoap commented 3 years ago

Remove one ineffectual assignment of 'done', eliminate one 'continue' and reuse 'err', since it's unproblematic.

The ineffectual assignment was found through https://goreportcard.com/report/github.com/pkg/sftp#ineffassign .

puellanivis commented 3 years ago

Changes to this function were already staged in https://github.com/pkg/sftp/pull/432 there’s a lot more changes coming down the pipe for the client.

I appreciate the effort, but this is staged for refactoring.

codesoap commented 3 years ago

Alright, thanks for the info, I didn't see that. Closing.