pkg / sftp

SFTP support for the go.crypto/ssh package
BSD 2-Clause "Simplified" License
1.5k stars 379 forks source link

Document the weirdness of the reversal of arguments to SSH_FXP_SYMLINK #525

Closed puellanivis closed 1 year ago

puellanivis commented 1 year ago

The reversal of arguments was documented in the encoding/ssh/filexfer.SymlinkPacket but had an unnoticed bug (odd coincidences) that pointed people to section 3.1 not 4.1.

The full comment with fix has been also brought into the sshFxpSymlinkPacket body to document also there why the arguments are reversed.