search

pkg / sftp

SFTP support for the go.crypto/ssh package
BSD 2-Clause "Simplified" License
1.52k stars 380 forks source link

Export RemoveFile method #548

Open narcisobenigno opened 1 year ago

narcisobenigno commented 1 year ago

This tries to address partially similar to issue #468 in our case.

In the same way we have the RemoveDirectory method as an exported method, we put the decision in the hands of the developer of which one to choose.

What do you think?

puellanivis commented 1 year ago

I’m kind of averse to this. We probably shouldn’t have exposed RemoveDirectory in the first place. As it seems it was exported as a least-change work-around for an issue people were seeing, but a more robust solution would have been to properly address the out-of-spec situation.

In the linked issue, I covered what the correct solution should be, I just haven’t had time to implement it.