Rework client to prevent after-Close usage, and support perm at Open

pkg / sftp

SFTP support for the go.crypto/ssh package

BSD 2-Clause "Simplified" License

1.49k stars 379 forks source link

Rework client to prevent after-Close usage, and support perm at Open #574

Closed puellanivis closed 5 months ago

puellanivis commented 6 months ago

Two things in this:

First, clear out the File.handle after a Close which can then be used to ensure that there is no use-after-close issue: https://github.com/pkg/sftp/issues/572
Second, after cleaning up other Client code, we can now easily implement the PR changes in: https://github.com/pkg/sftp/pull/567

puellanivis commented 5 months ago

Alright, I feel this is pretty solid now. I’ll be merging it shortly.

drakkan commented 5 months ago

Alright, I feel this is pretty solid now. I’ll be merging it shortly.

I plan to do some testing this weekend, but I'm sure I won't find anything wrong. Sounds like a great job, thanks!

puellanivis commented 5 months ago

I plan to do some testing this weekend, but I'm sure I won't find anything wrong. Sounds like a great job, thanks!

I’ll hold off until Monday then. More broad testing is better than the very narrow testing that I’ve done so far.

drakkan commented 5 months ago

LGTM, since we are adding support for perm at Open for the server implementation maybe we can also add them in requestFromPacket for the request server, but we can also delay this to a future PR if required.

puellanivis commented 5 months ago

Adding support in requestFromPacket was simple enough. Just a one-liner. Adding deeper support to the MemFile implementation to act as an example would take much more work, so I’ll leave that part for a later PR… or an existing PR. :trollface:

drakkan commented 5 months ago

Adding support in requestFromPacket was simple enough. Just a one-liner. Adding deeper support to the MemFile implementation to act as an example would take much more work, so I’ll leave that part for a later PR… or an existing PR. :trollface:

Thank you!