search

pkg / term

Package term manages POSIX terminals.
BSD 2-Clause "Simplified" License
392 stars 66 forks source link

Fix FreeBSD support #18

Closed dumbbell closed 8 years ago

dumbbell commented 8 years ago

The following two commits were necessary to make this module build on FreeBSD 11-CURRENT. It was tested successfully from Concourse's fly CLI (see https://github.com/concourse/fly).

I admit I didn't test on other BSD flavors. I know nothing about the Go langage so your comments on this patch are welcome!

davecheney commented 8 years ago

Thank you. I need to investigate that wercker failure, and probably change this project to use travis

davecheney commented 8 years ago

@dumbbell I tried to test this on my freebsd system but the tests to not pass (but they didn't before either). Can you please rebase against master and try again. Thanks.

dumbbell commented 8 years ago

Here are the results of the testsuite on the three operating systems I tried:

I don't understand the failure on FreeBSD but I didn't investigate much either.

davecheney commented 8 years ago

Thanks. I'll test on my 10.3 machine. Can you plus push your branch.

Also, #15

On 20 May 2016, at 19:18, Jean-Sébastien Pédron notifications@github.com wrote:

Here are the results of the testsuite on the three operating systems I tried:

FreeBSD 11-CURRENT with Go 1.6.2

=== RUN TestTermSetCbreak --- PASS: TestTermSetCbreak (0.00s) === RUN TestTermSetRaw --- PASS: TestTermSetRaw (0.00s) === RUN TestTermSetSpeed --- PASS: TestTermSetSpeed (0.00s) === RUN TestTermSetReadTimeout --- PASS: TestTermSetReadTimeout (0.00s) === RUN TestTermSetFlowControl --- PASS: TestTermSetFlowControl (0.00s) === RUN TestTermRestore --- PASS: TestTermRestore (0.00s) PASS ok github.com/pkg/term 0.004s === RUN TestTcflush --- PASS: TestTcflush (0.00s) === RUN TestTcgetattr --- PASS: TestTcgetattr (0.00s) === RUN TestTcsetattr --- PASS: TestTcsetattr (0.00s) === RUN TestTcsendbreak --- FAIL: TestTcsendbreak (0.00s) termios_test.go:43: inappropriate ioctl for device === RUN TestTcdrain --- PASS: TestTcdrain (0.00s) === RUN TestTiocmget --- PASS: TestTiocmget (0.00s) === RUN TestTiocmset --- PASS: TestTiocmset (0.00s) === RUN TestTiocmbis --- PASS: TestTiocmbis (0.00s) === RUN TestTiocmbic --- PASS: TestTiocmbic (0.00s) === RUN TestTiocinq --- PASS: TestTiocinq (0.00s) === RUN TestTiocoutq --- PASS: TestTiocoutq (0.00s) === RUN TestCfgetispeed --- PASS: TestCfgetispeed (0.00s) === RUN TestCfgetospeed --- PASS: TestCfgetospeed (0.00s) FAIL FAIL github.com/pkg/term/termios 0.004s Debian Jessie with Go 1.5.1

=== RUN TestTermSetCbreak --- PASS: TestTermSetCbreak (0.00s) === RUN TestTermSetRaw --- PASS: TestTermSetRaw (0.00s) === RUN TestTermSetSpeed --- PASS: TestTermSetSpeed (0.00s) === RUN TestTermSetReadTimeout --- PASS: TestTermSetReadTimeout (0.00s) === RUN TestTermSetFlowControl --- PASS: TestTermSetFlowControl (0.00s) === RUN TestTermRestore --- PASS: TestTermRestore (0.00s) PASS ok github.com/pkg/term 0.002s === RUN TestTcflush --- PASS: TestTcflush (0.00s) === RUN TestTcgetattr --- PASS: TestTcgetattr (0.00s) === RUN TestTcsetattr --- PASS: TestTcsetattr (0.00s) === RUN TestTcsendbreak --- PASS: TestTcsendbreak (0.00s) === RUN TestTcdrain --- PASS: TestTcdrain (0.00s) === RUN TestTiocmget --- SKIP: TestTiocmget (0.00s) termios_test.go:169: invalid argument === RUN TestTiocmset --- SKIP: TestTiocmset (0.00s) termios_test.go:169: invalid argument === RUN TestTiocmbis --- SKIP: TestTiocmbis (0.00s) termios_test.go:169: invalid argument === RUN TestTiocmbic --- SKIP: TestTiocmbic (0.00s) termios_test.go:169: invalid argument === RUN TestTiocinq --- PASS: TestTiocinq (0.00s) === RUN TestTiocoutq --- PASS: TestTiocoutq (0.00s) === RUN TestCfgetispeed --- PASS: TestCfgetispeed (0.00s) === RUN TestCfgetospeed --- PASS: TestCfgetospeed (0.00s) PASS ok github.com/pkg/term/termios 0.003s OS X 10.11.5 with Go 1.6.2

=== RUN TestTermSetCbreak --- PASS: TestTermSetCbreak (0.00s) === RUN TestTermSetRaw --- PASS: TestTermSetRaw (0.00s) === RUN TestTermSetSpeed --- PASS: TestTermSetSpeed (0.00s) === RUN TestTermSetReadTimeout --- PASS: TestTermSetReadTimeout (0.00s) === RUN TestTermSetFlowControl --- PASS: TestTermSetFlowControl (0.00s) === RUN TestTermRestore --- PASS: TestTermRestore (0.00s) PASS ok github.com/pkg/term 0.008s === RUN TestTcflush --- PASS: TestTcflush (0.00s) === RUN TestTcgetattr --- PASS: TestTcgetattr (0.00s) === RUN TestTcsetattr --- PASS: TestTcsetattr (0.00s) === RUN TestTcsendbreak --- PASS: TestTcsendbreak (0.00s) === RUN TestTcdrain --- PASS: TestTcdrain (0.00s) === RUN TestTiocmget --- SKIP: TestTiocmget (0.00s) termios_test.go:169: inappropriate ioctl for device === RUN TestTiocmset --- SKIP: TestTiocmset (0.00s) termios_test.go:169: inappropriate ioctl for device === RUN TestTiocmbis --- SKIP: TestTiocmbis (0.00s) termios_test.go:169: inappropriate ioctl for device === RUN TestTiocmbic --- SKIP: TestTiocmbic (0.00s) termios_test.go:169: inappropriate ioctl for device === RUN TestTiocinq --- PASS: TestTiocinq (0.00s) === RUN TestTiocoutq --- PASS: TestTiocoutq (0.00s) === RUN TestCfgetispeed --- PASS: TestCfgetispeed (0.00s) === RUN TestCfgetospeed --- PASS: TestCfgetospeed (0.00s) PASS ok github.com/pkg/term/termios 0.009s I don't understand the failure on FreeBSD but I didn't investigate much either.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub

dumbbell commented 8 years ago

Can you plus push your branch.

What do you mean?

Also, #15

Oh, I missed that. I will contact swills@, in case this patch helps him too.

davecheney commented 8 years ago

Please push once you've rebated, sorry, autocorrect

On 20 May 2016, at 19:28, Jean-Sébastien Pédron notifications@github.com wrote:

Can you plus push your branch.

What do you mean?

Also, #15

Oh, I missed that. I will contact swills@, in case this patch helps him too.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub

dumbbell commented 8 years ago

I already rebased on the latest master.

davecheney commented 8 years ago

Thanks

On 20 May 2016, at 19:30, Jean-Sébastien Pédron notifications@github.com wrote:

I already rebased on the latest master.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub

davecheney commented 8 years ago

Thanks. This is a good checkpoint, we can chase these final tests in a followup commit.