search

pkg / term

Package term manages POSIX terminals.
BSD 2-Clause "Simplified" License
392 stars 66 forks source link

Compile on DragonFly BSD, NetBSD, and OpenBSD #30

Closed mndrix closed 5 years ago

mndrix commented 6 years ago

This fixes issue #25 for me on OpenBSD. This should work on DragonFly BSD and NetBSD too, based on their man pages, but I don't have access to those machines for testing myself.

leonklingele commented 5 years ago

What's blocking a merge here? Would be nice to have this landed.

bndw commented 5 years ago

@davecheney I know there's some OpenBSD history in this repo, but this patch would be really helpful. Please let me know if I can assist in getting this merged.

leonklingele commented 5 years ago

@mndrix this works fine on OpenBSD and NetBSD, however fails on DragonFlyBSD:

vendor/github.com/pkg/term/term.go:70:9: undefined: termios.Tiocinq
vendor/github.com/pkg/term/term.go:77:9: undefined: termios.Tiocoutq
vendor/github.com/pkg/term/term_open_posix.go:20:12: undefined: termios.Tcgetattr
vendor/github.com/pkg/term/term_open_posix.go:32:9: undefined: termios.Tcsetattr
vendor/github.com/pkg/term/term_posix.go:27:12: undefined: termios.Tcgetattr
vendor/github.com/pkg/term/term_posix.go:31:9: undefined: termios.Tcsetattr
vendor/github.com/pkg/term/term_posix.go:42:12: undefined: termios.Tcgetattr
vendor/github.com/pkg/term/term_posix.go:46:9: undefined: termios.Tcsetattr
vendor/github.com/pkg/term/term_posix.go:63:12: undefined: termios.Tcgetattr
vendor/github.com/pkg/term/term_posix.go:67:9: undefined: termios.Tcsetattr
vendor/github.com/pkg/term/term_posix.go:67:9: too many errors
$ uname -a
DragonFly dragonfly502 5.0-RELEASE DragonFly v5.0.2-RELEASE #4: Sun Dec  3 17:42:25 EST 2017     root@www.shiningsilence.com:/usr/obj/home/justin/release/5_0/sys/X86_64_GENERIC  x86_64
leonklingele commented 5 years ago

Fix for DragonFlyBSD is in #37.