search

pkg / term

Package term manages POSIX terminals.
BSD 2-Clause "Simplified" License
393 stars 64 forks source link

golang.syscall to golang.org/x/sys #38

Closed Konstantin8105 closed 4 years ago

Konstantin8105 commented 5 years ago

Hello,

In according to https://golang.org/pkg/syscall:

Deprecated: this package is locked down. Callers should use the corresponding package in the golang.org/x/sys repository instead.

In my point of view, we have to update. Please clarify your point of view.

davecheney commented 5 years ago

Is there something missing from the syscall package that this package needs?

On 4 Nov 2018, at 20:56, Konstantin notifications@github.com wrote:

Hello,

In according to https://golang.org/pkg/syscall:

Deprecated: this package is locked down. Callers should use the corresponding package in the golang.org/x/sys repository instead.

In my point of view, we have to update. Please clarify your point of view.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

Konstantin8105 commented 5 years ago

At the preliminary view, all is same, but with small separation by OS: https://godoc.org/golang.org/x/sys

Also struct of Termios changed from:

type Termios struct {
        Iflag     uint32
        Oflag     uint32
        Cflag     uint32
        Lflag     uint32
        Line      uint8
        Cc        [32]uint8
        Pad_cgo_0 [3]byte
        Ispeed    uint32
        Ospeed    uint32
}

to:

type Termios struct {
    Iflag  uint32
    Oflag  uint32
    Cflag  uint32
    Lflag  uint32
    Line   uint8
    Cc     [19]uint8
    Ispeed uint32
    Ospeed uint32
}
davecheney commented 5 years ago

In which os? Was this change backported to the syscall package?

On 4 Nov 2018, at 21:02, Konstantin notifications@github.com wrote:

At the preliminary view, all is same, but with small separation by OS: https://godoc.org/golang.org/x/sys

Also struct of Termios changed from:

type Termios struct { Iflag uint32 Oflag uint32 Cflag uint32 Lflag uint32 Line uint8 Cc [32]uint8 Pad_cgo_0 [3]byte Ispeed uint32 Ospeed uint32 } to:

type Termios struct { Iflag uint32 Oflag uint32 Cflag uint32 Lflag uint32 Line uint8 Cc [19]uint8 Ispeed uint32 Ospeed uint32 } — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

Konstantin8105 commented 5 years ago

I only unix package. Us I understood, if fields of struct Termios are changed , so structs syscall.Termios and unix.Termios are not comparable. So no backport.

davecheney commented 5 years ago

I’d prefer not to take an extra dependency. If there is a bug that is caused by an incompatibility between the two syscall packages let’s talk about that concretely.

On 4 Nov 2018, at 21:13, Konstantin notifications@github.com wrote:

I only unix package. Us I understood, if fields of struct Termios are changed , so structs syscall.Termios and unix.Termios are not comparable. So no backport.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

davecheney commented 4 years ago

I've switched to x/sys now.