pkgcore / pkgcheck

pkgcore-based QA utility for ebuild repos
https://pkgcore.github.io/pkgcheck
BSD 3-Clause "New" or "Revised" License
34 stars 29 forks source link

SrcUriFilenameDotPrefix: new check for SRC_URI filenames with dot prefix #592

Closed arthurzam closed 1 year ago

arthurzam commented 1 year ago

Resolves: https://github.com/pkgcore/pkgcheck/issues/585

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01 :warning:

Comparison is base (afc779b) 79.88% compared to head (e48c3ef) 79.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #592 +/- ## ========================================== - Coverage 79.88% 79.88% -0.01% ========================================== Files 57 57 Lines 8536 8545 +9 Branches 1939 1941 +2 ========================================== + Hits 6819 6826 +7 - Misses 1617 1618 +1 - Partials 100 101 +1 ``` | [Impacted Files](https://app.codecov.io/gh/pkgcore/pkgcheck/pull/592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pkgcore) | Coverage Δ | | |---|---|---| | [src/pkgcheck/checks/metadata.py](https://app.codecov.io/gh/pkgcore/pkgcheck/pull/592?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pkgcore#diff-c3JjL3BrZ2NoZWNrL2NoZWNrcy9tZXRhZGF0YS5weQ==) | `89.29% <80.00%> (-0.11%)` | :arrow_down: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

mgorny commented 1 year ago

I wonder if we shouldn't simply put it in bad_filenames.

arthurzam commented 1 year ago

I wonder if we shouldn't simply put it in bad_filenames.

@mgorny I'm unsure about it. While simpler, the BadFilename is quite ambiguous, and I'm unsure anybody will understand what it means in practice. Here we have a more specialized case, where we warn the develop - "you might have done big mistake, reverify".

I think it will be better to have more info than less here.