pkgcore / pkgcheck

pkgcore-based QA utility for ebuild repos
https://pkgcore.github.io/pkgcheck
BSD 3-Clause "New" or "Revised" License
34 stars 29 forks source link

PerlCheck: check versioned virtual perl dependencies #597

Closed arthurzam closed 12 months ago

arthurzam commented 1 year ago

@akhuettel @thesamesam So here it is. A huge amount of matches across the repo. After some talks on IRC (#-perl) this is done as optional check, so folks need to enable PerlCheck for this result to appear.

I'm fine with any decision (merge or decline), so don't feel obligated πŸ˜„

Resolves: https://github.com/pkgcore/pkgcheck/issues/593

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 :tada:

Comparison is base (2b9b8e7) 79.77% compared to head (59cfd9b) 79.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #597 +/- ## ========================================== + Coverage 79.77% 79.82% +0.04% ========================================== Files 58 58 Lines 8652 8673 +21 Branches 1966 1972 +6 ========================================== + Hits 6902 6923 +21 Misses 1648 1648 Partials 102 102 ``` | [Impacted Files](https://app.codecov.io/gh/pkgcore/pkgcheck/pull/597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pkgcore) | Coverage Ξ” | | |---|---|---| | [src/pkgcheck/checks/perl.py](https://app.codecov.io/gh/pkgcore/pkgcheck/pull/597?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pkgcore#diff-c3JjL3BrZ2NoZWNrL2NoZWNrcy9wZXJsLnB5) | `100.00% <100.00%> (ΓΈ)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

arthurzam commented 1 year ago

So we have:

[23:18:57] <@dilfridge> off by default is ok

So I guess we can continue with this and review before merge...