search

pkgcore / pkgcheck

pkgcore-based QA utility for ebuild repos
https://pkgcore.github.io/pkgcheck
BSD 3-Clause "New" or "Revised" License
34 stars 29 forks source link

Git remote currently required to be named "origin", please allow other remote names via configuration #600

Closed hartwork closed 12 months ago

hartwork commented 1 year ago

Hi!

Currently, the code at https://github.com/pkgcore/pkgcheck/blob/master/src/pkgcheck/addons/git.py hardcodes remote name origin in multiple places which e.g. results in weird errors (see below) for users that avoid name origin for safety reasons, e.g. my remote is named git-gentoo-org instead.

The symptom with pkgcheck scan is this:

# pkgcheck scan --commits 331a06d2a333b02996e9cc49ab55441c9bd749bd^..331a06d2a333b02996e9cc49ab55441c9bd749bd
pkgcheck scan: error: failed retrieving commit hash for git repo: '[..]/gentoo-GIT'

Renaming the remote git remote rename git-gentoo-org origin works around the issue but forces magic name origin on me that I use nowhere else.

I understand if this is not considered high priority. Thanks for your consideration :pray:

Sebastian

CC @thesamesam