Closed arthurzam closed 12 months ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
4e9dbc1
) 79.75% compared to head (123abbc
) 79.75%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Hi @arthurzam very nice and quick — thank you! pray
I have tried both (1)
--git-remote git-gentoo-org
and (2) the config option with noorigin
in sight now and it worked with each of these in isolation and did not work by default (as expected). That's great.
Thank you :)
For anyone else interested, the config file looked like this for me in practice:
# cat ~/.config/pkgcheck/pkgcheck.conf [DEFAULT] git-remote = git-gentoo-org
One thing I noticed is that in the config file
git-remote
(with a dash) could be an unusual key format/syntax here if nothing else uses a dash so far (not sure); if so,git_remote
with an underscore may work better, just an idea.
At pkgcore stack we use the -
symbol for command line arguments word separation (python's argparse converts it into _
for the option variable name). I think this style also makes better sense compared to git
and the --
prefix :) so we should be same style. But thank you for the concern and verifying it.
I'll merge it now.
For repos with multiple remotes, it might be useful to select a specific remote to use (and not the default origin). This can be set using the
--git-remote
option for cmd call, or by addinggit-remote=value
to the config file.@hartwork mind applying the patch and verifying if it work for you (ideally both ways of cmd arg and config file).
Resolves: https://github.com/pkgcore/pkgcheck/issues/600