search

pkgcore / pkgcheck

pkgcore-based QA utility for ebuild repos
https://pkgcore.github.io/pkgcheck
BSD 3-Clause "New" or "Revised" License
34 stars 29 forks source link

EclassManualDepsCheck: add check for missing manual deps #616

Closed arthurzam closed 10 months ago

arthurzam commented 10 months ago

Whn in special modes of eclasses (for example CARGO_OPTIONAL=1), verify specific dependencies are listed somehow in one of the dependencies var.

For commit https://github.com/gentoo/gentoo/commit/2a8a35c8cf88eb696e9ad08e22103b0e94397e7b, I get those results:

dev-python/cryptography
  RustMissingDeps: version 41.0.3: sets CARGO_OPTIONAL but does not depend on virtual/rust

sys-apps/portage
  TmpfilesMissingDeps: version 3.0.45.3-r2: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 3.0.46: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 3.0.49-r2: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 3.0.50: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 3.0.51: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 9999: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles

sys-libs/glibc
  TmpfilesMissingDeps: version 2.19-r2: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.31-r7: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.32-r8: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.33-r14: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.34-r14: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.35-r11: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.36-r8: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.37-r3: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.37-r4: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 2.38-r1: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles
  TmpfilesMissingDeps: version 9999: sets TMPFILES_OPTIONAL but does not depend on virtual/tmpfiles

Resolves: https://github.com/pkgcore/pkgcheck/issues/615

TODO: