search

pkgcore / pkgcheck

pkgcore-based QA utility for ebuild repos
https://pkgcore.github.io/pkgcheck
BSD 3-Clause "New" or "Revised" License
35 stars 29 forks source link

[New Check]: Add LuaMissingRequiredUse, like for Python #646

Open thesamesam opened 8 months ago

thesamesam commented 8 months ago

Is there an existing such new check request for this?

Explain

The Lua eclasses in Gentoo are based on the proven model that we use for packaging Python.

We have a check for missing ${PYTHON_REQUIRED_USE} with the Python eclasses since 4b14290a3225fa24507f0876a851f73b4bc9c391.

We could do with a similar check for Lua (and maybe we should look if any other checks for Python are applicable to Lua), otherwise the ebuild will fail in pkg_setup if no valid Lua implementation (per LUA_COMPAT) is set.

Examples

app-admin/conky-1.19.2-r1, fixed in cae6deea1f6abda4e9e88e32881f396186d4c6aa

Output message

LuaMissingRequiredUSE

Documentation

Lua is missing LUA_REQUIRED_USE.

Result level

warning

thesamesam commented 8 months ago

Looks like we're missing LuaMissingDeps for LUA_DEPEND too at least. And maybe a warning for directly depending on dev-lang/lua...