search

pkgcore / pkgcheck

pkgcore-based QA utility for ebuild repos
https://pkgcore.github.io/pkgcheck
BSD 3-Clause "New" or "Revised" License
34 stars 29 forks source link

Promote `PkgBadlyFormedXml` from Warning to Error #668

Closed APN-Pucky closed 4 months ago

APN-Pucky commented 4 months ago

::sci runs pkgcheck scan in it's CI, but since this is only a warning the CI does not fail. I think requiring metadata.xml to be a correctly formatted is reasonable and PkgBadlyFormedXml should be treated as an error.

The QA CI https://bugs.gentoo.org/922385 reports this as a failure, so it should be an error here too.

Since this did go unnoticed in ::sci it has been dropped from repology (See https://github.com/repology/repology-updater/commit/688fc91d1092e3c7b7b5c79bd03935bb54e872b1).

Cross-reference: https://github.com/gentoo/sci/pull/1252

arthurzam commented 4 months ago

After some more checks, I see no issue with upgrading it to error. I'm more surprised it was a warning before.