[Bug]: pkgcheck does not verify make.defaults quoting requirement - Githubissues

pkgcore / pkgcheck

pkgcore-based QA utility for ebuild repos

https://pkgcore.github.io/pkgcheck

BSD 3-Clause "New" or "Revised" License

35 stars 29 forks source link

[Bug]: pkgcheck does not verify make.defaults quoting requirement #692

Open Jannik2099 opened 3 months ago

Jannik2099 commented 3 months ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

see https://bugs.gentoo.org/935685

make.defaults syntax is defined in PMS 5.2.4:

The file itself is a line-based key-value format. Each line contains a single VAR="value" entry, where the value must be double quoted.

pkgcheck does not seem to warn on unquoted VAR=value lines, as have been present for a while e.g. in https://github.com/gentoo/gentoo/blob/595c607772111487ab160081434422a98118e566/profiles/features/llvm/make.defaults#L34

Expected Behavior

No response

pkgcheck version

pkgcheck 0.10.30

pkgcore version

pkgcore 0.12.27