pkgcore / pkgdev

collection of tools for Gentoo development
https://pkgcore.github.io/pkgdev/
BSD 3-Clause "New" or "Revised" License
29 stars 11 forks source link

`pkgdev manifest` doesn't proceed to generate manifests for existing files on fetch failures #101

Closed l29ah closed 1 year ago

l29ah commented 1 year ago

I don't want to fetch anything not already present in my system on a metered gsm/satellite link. --if-modified could /mostly/ suffice, but it's broken as well.

thesamesam commented 1 year ago

We usually ask that people give some example ebuilds and output to understand the problem.

I'm afraid it's unclear to me what the issue is. Can you elaborate, ideally showing the state of the Manifest and sequence of events?

arthurzam commented 1 year ago

In this case, I know about this issue, so no need for examples - issue known, solution still not.

Also, as a parallel discussion, I'm not sure I understand what is your flow in your tree? --if-modified uses only staged/unstaged files, but not from previous commits, so the flow just sounds weird.

l29ah commented 1 year ago

Also, as a parallel discussion, I'm not sure I understand what is your flow in your tree? --if-modified uses only staged/unstaged files, but not from previous commits, so the flow just sounds weird.

The usual flow would be just as with --if-modified except there would be no need to specify --if-modified. But when the repo conf changes, e.g., the used list of hashes, pkgdev would ideally rehash all the present distfiles.

arthurzam commented 1 year ago

The usual flow would be just as with --if-modified except there would be no need to specify --if-modified. But when the repo conf changes, e.g., the used list of hashes, pkgdev would ideally rehash all the present distfiles.

OK, thank you for the information. Currently, pkgdev manifest won't rehash all manifests during configuration change unless an entry has missing required hash (from another config line), FYI.

@l29ah Can you check if using the patch https://github.com/pkgcore/pkgcore/pull/371 applied to pkgcore fixes the current issue for you?