search

pkgjs / create-pkg

Scaffolding for JavaScript
10 stars 4 forks source link

chore(monorepo): initial commit to create the create-pkg monorepo #18

Closed rxmarbles closed 6 months ago

rxmarbles commented 7 months ago

This PR initalizes the move of create-pkg from a singular repo to a monorepo starting w/ the create-pkg CLI as per #16 . There are things that are needed to be added at the root README level which I'm hoping to structure out once we move more packages in. We can also link to the package-meta-interop collabspace for more of the research and drivers for the work being done to these packages

cc @Ethan-Arrowood

In regards to maintaining git history for the rest of the packages that we plan on moving into the repo we can use lerna import. Once we have all the packages that we feel are necessary for the project we can freely remove lerna and go with a pure npm workspaces setup. Just my 2 cents but feel it would get us going on the project and implement/experiment quickly to work towards our goals. Happy to discuss further.

wesleytodd commented 7 months ago

I got curious, so I looked up learna import and I am confident there is a much better way to do this with git directly. But here is the link for anyone interested: https://github.com/lerna/lerna/blob/main/libs/commands/import/src/index.ts

Ethan-Arrowood commented 7 months ago

Lerna isn't necessary afaik to retain git history. Ive done migrations like this with git alone. But if lerna worked then no big deal let's ship it 🚀

wesleytodd commented 7 months ago

Yeah, maybe it is not worth even worrying about this until the first package is pulled in? We only need to pull in like 2 things afaik so we should't get too hung up on it.

wesleytodd commented 6 months ago

We were on the call and @darcyclarke and I both just said we are good to merge. So I just merged.