search

pkgjs / parseargs

Polyfill of `util.parseArgs()`
Apache License 2.0
121 stars 9 forks source link

chore: most recent code review changes #118

Closed bcoe closed 2 years ago

bcoe commented 2 years ago

upstream changes from most recent code review.

shadowspawn commented 2 years ago

Added Ian's suggestions.

Edit: sorry, misunderstood direction of changes. To be clear, applied here and not in node PR!

shadowspawn commented 2 years ago

Removed stale type default of boolean in API docs, which has already been applied upstream.

shadowspawn commented 2 years ago

I did a file compare against matching upstream files for index.js, utils.js, and README.md. Just picked up one non-whitespace difference and added a suggestion on the PR to catch up: