pkgjs / parseargs

Polyfill of `util.parseArgs()`
Apache License 2.0
121 stars 9 forks source link

refactor!: drop handling of electron arguments #121

Closed bcoe closed 2 years ago

bcoe commented 2 years ago

@ljharb raised concerns in https://github.com/nodejs/node/pull/42675 that process.defaultApp is an electron-specific property added to process, and not a well known property "blessed" by Node.js itself.

I also noticed we have no tests that cover accessing process.defaultApp.


tldr; I think supporting Electron is likely a good call, and we should add this behavior back, but let's do it as a follow on PR, post landing the MVP -- rather than add any additional complexity to https://github.com/nodejs/node/pull/42675.