package metadata should match the license file

pkgjs / parseargs

Polyfill of `util.parseArgs()`

Apache License 2.0

123 stars 10 forks source link

Open yufukui-m opened 3 months ago

yufukui-m commented 3 months ago

which license is correct, in package.json or LICENSE?

shadowspawn commented 3 months ago

Related: #153

ljharb commented 3 months ago

The package declaration imo is correct, not the license file.

shadowspawn commented 3 months ago

I suspect it is a mess to land a fix. We might need agreement from all previous contributors, and a major version release to change the licence.

I am a contributor, and I don't mind which licence we use. I prefer MIT as shorter and I think more common for npm packages.

ljharb commented 3 months ago

We don’t need a major version if we’re not changing the license field, because that’s the only thing tools look at.

We may indeed want to confirm that contributors werent confused by the incorrect license file, though.