search

pkgjs / support

Package Support Format
MIT License
24 stars 7 forks source link

Add files section to package.json to avoid to publish test fixture files #33

Closed helio-frota closed 3 years ago

helio-frota commented 3 years ago

Currently npm shows 157 files 

Unpacked Size 
74.6 kB

Total Files
157

That is because support was published with test fixtures:

$ tar -tf pkgjs-support-0.0.3.tgz 
package/test/cli/show-local-circular-dependency/command
package/test/cli/show-local-escape-ok/command
package/test/cli/show-local-escape/command
package/test/cli/show-local-path1/command
package/test/cli/show-local-path2/command
package/test/cli/show-local-tree-flat/command
package/test/cli/show-local-tree/command
package/test/cli/show-local/command
...

It would be good to have a files section on package.json to avoid publishing fixture files.

ljharb commented 3 years ago

There’s disagreement on that front. I believe all npm packages should always publish all tests, so that npm explore foo && npm install && npm test always works.

helio-frota commented 3 years ago

@ljharb interesting and I just learned about the existence of npm explore. Thanks for share your opinion. :+1: So yeah, in that case I'm ok on closing this issue.