search

pkgjs / support

Package Support Format
MIT License
24 stars 7 forks source link

add Node.js 18, 20 and 22 to `engines` #51

Closed richardlau closed 1 month ago

richardlau commented 1 month ago

npm 10.8.2 doesn't install the latest tagged version of @pkgjs/support with Node.js 22 as Node.js 22 is outside of the declared specification for engines->node.

Regardless of whether the change in behaviour of npm is correct for a semver-patch release of npm, update the engines field to include the supported Node.js release lines at this point in time.

Refs: https://github.com/npm/cli/issues/7704#issuecomment-2273669343

richardlau commented 1 month ago

hmm. It looks like tests are broken everywhere (even for the older Node.js versions that this PR doesn't change). 😞

wesleytodd commented 1 month ago

We should probably just change this to >10 at this point right? Just not sure there is value in enumerating them like this?

richardlau commented 1 month ago

We should probably just change this to >10 at this point right? Just not sure there is value in enumerating them like this?

I don't think so -- I was going with "don't disturb anything already there". I've updated the field to >=10.19 (I assume the existing ^10.19 was there for a reason).