search

pkgjs / wiby

"Will I break you" - a tool for testing dependents
Apache License 2.0
33 stars 7 forks source link

Re-use existing branches #101

Closed dominykas closed 3 years ago

dominykas commented 3 years ago

Closes #95

ghinks commented 3 years ago

As part of simple due diligence I pulled the branch and ran the tests locally. For me I see issues with test/internals/github-integration.js.

I am looking further.

Screen Shot 2021-07-19 at 11 00 03 AM Screen Shot 2021-07-19 at 10 58 17 AM
dominykas commented 3 years ago

For me I see issues with test/internals/github-integration.js.

These specific tests need a valid GITHUB_TOKEN exposed. They get skipped if there is no token at all - maybe you had one for some other GH instance?

dominykas commented 3 years ago

@ghinks as these tests are passing for me locally, and also in CI, I'll assume that all is fine and merge this - ping me if you want to dig deeper to see what's going in there?

dominykas commented 3 years ago

:tada: This PR is included in version 0.9.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: