lib: handle not published packages

BethGriggs commented 4 years ago

This PR removes the need for modules to be published to npm before they can be tested. This involved a bit more refactoring than I first anticipated...

To summarise, this PR:

Introduces git-url-parse module
Extracts the parent module repository from the local package.json using the git-url-parse module.
- This enables us to remove getGitHubOrgRepo, getOrgRepo, and fetchRegistryInfo functions.
Renames variables such as dep
- These changes were initially to just to help me understand the flow of the program, but I think it is worth keeping more specific naming - although happy to change these.
Changes the getPatch function name to getCommitURL
- Open to bike-shedding on this function name. I felt it should be changed as when I was working through the code I assumed that the function returned a Git Patch, but it returns the URL that we wish to patch the package.json with.
Removes the tests for the removed functions. Updates the test for getPatch where the function has been renamed.

BethGriggs commented 4 years ago

It might be easier to review the file in full - https://github.com/pkgjs/wiby/blob/5a124183b53d432170315b541d864a3cdae12a88/lib/test.js

BethGriggs commented 4 years ago

Thanks @rodion-arr, I've addressed the unused var.

I think there's an ongoing discussion about our choice of linter, so I may defer adding standard to the test script for a later PR.

dominykas commented 4 years ago

[x] At least 1 approval from package-maintenance members other than the author of the PR, unless there is single maintainer for the repository. In that case the single maintainer can land their own PRs.
[x] No blocking reviews
[x] 72 hours since the PR was openened

dominykas commented 3 years ago

:tada: This PR is included in version 0.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

pkgjs / wiby

lib: handle not published packages #14