Update package.json - Githubissues

pkgjs / wiby

"Will I break you" - a tool for testing dependents

Apache License 2.0

33 stars 7 forks source link

Update package.json #65

Closed rodion-arr closed 3 years ago

rodion-arr commented 3 years ago

Adds support info
Adds engines field

Closes #62

rodion-arr commented 3 years ago

I'm not fully confident in engines field, so if I've put not correct value, will be happy to update.

Based on CI - we run on LTS + v15. But I'm not sure how engine field like "^15 || ^14 || ^13 || ^12 || ^10" will behave in case this package will be installed on non-LTS, so I just put v10+.

ljharb commented 3 years ago

It should behave fine. If we don’t want to support node 11 (or 13, which also isn’t lts) we need the ^ form.

rodion-arr commented 3 years ago

Thanks, updated

dominykas commented 3 years ago

Thanks for this PR!

I'm not sure we should "support" v15 - we should use lts_active policy instead and remove the v15 from the engines. Testing in v15 is just to get a heads up before the next LTS.

dominykas commented 3 years ago

:tada: This PR is included in version 0.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: