pkgjs / wiby

"Will I break you" - a tool for testing dependents
Apache License 2.0
33 stars 7 forks source link

fix: use name from package json within the patch #67

Closed ghinks closed 3 years ago

ghinks commented 3 years ago

To make myself more familiar with wiby I started testing with two repos created for testing purposes.

The dependency repo my-dependency-id-a and the parent consuming it

the target modules would be @gvhinks/my-dependency-id-a and the parent @gvhinks/my-parent.

What I found was that the name from the package.json should be used and not the repo name in the patch as some names will be scoped and we should not assume the repo and package name are the same.

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or

(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.

(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.

dominykas commented 3 years ago

Thanks! Mind adding a test?

BTW, my understanding is that the DCO can stay in the comment.

ghinks commented 3 years ago

updates to unit test as suggested from the previous review.

dominykas commented 3 years ago

:tada: This PR is included in version 0.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: