Closed ghinks closed 3 years ago
Looking at the tests again as they pass locally. Looks like osx !== ubuntu.
still in progress, a few more bits to tidy up yet.
still a work in progress, looking at things I broke on the result call now.
I had a look at the query you suggested and it looks like a much better way to do things. I will close this PR and open another with that change.
During testing using a parent repo that had a dependency upon.
The repos did not use master but main I found issues as the default branch was hardcoded to master.
I created a getDefaultBranch query to get the default branch to github.js
I added both unit and integration tests to cover this.
This is the first time I have used tap and am glad of advice :)
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I have the right to submit it under the open source license indicated in the file; or
(b) The contribution is based upon previous work that, to the best of my knowledge, is covered under an appropriate open source license and I have the right under that license to submit that work with modifications, whether created in whole or in part by me, under the same open source license (unless I am permitted to submit under a different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person who certified (a), (b) or (c) and I have not modified it.
(d) I understand and agree that this project and the contribution are public and that a record of the contribution (including all personal information I submit with it, including my sign-off) is maintained indefinitely and may be redistributed consistent with this project or the open source license(s) involved.