Closed dominykas closed 3 years ago
I'm going to review to the best of my abilities here. The instructions are clear and I could follow and understand them. I am still getting up to speed on github actions and am learning from reading the wiby.yaml file. So will not review that section.
I did however release these changes as a module under my own organization @gvhinks/wiby so I could test with it. I could not quite work out what was required in order to trigger the wiby action.
A "wiby test" comment in a PR, and then a "wiby result" comment to check for results. Less, then ideal :( but best I could come up with (and build in short time to get a PoC).
I carried out a bit of experimentation by taking the changes and releasing a wiby module in a private namespace. When updating a dependency using the instructions in the PR the wiby action does the push to the dependent repo but does not get marked as completed.
If you comment "wiby result" after all the tests completed - it should go green.
Do you have a link to the PR? I can take a look at the output...
yes, ( apologies , work got in the way ).
did as suggested ( still getting up to speed on actions ) , seemed to do the trick.
Thanks for the reviews and test here @ghinks 🙇
@pkgjs/wiby-collaborators can I get some ✅ here please?
:tada: This PR is included in version 0.3.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
See https://github.com/pkgjs/wiby/pull/69/files#diff-00505182d7d4129a98ee7fb7b652a1ef6b608d7620a681914db3a7a4903eee9f for usage details.
Marking this ready for review to get feedback, but we can't merge this without the following:
WIBY_TOKEN
I have also added a bunch of notes on https://github.com/pkgjs/wiby/issues/56#issuecomment-768301949 on how to move this forward, but I figure I'll want to make some changes to the wiby CLI first, rather than the GH actions, and I'd also like to start getting this to a more demoable place and also to start test driving this on wiby itself, even if it still requires some manual interaction (namely deleting the
wiby-wiby
branch in thewiby-test
org).