pkgjs / wiby

"Will I break you" - a tool for testing dependents
Apache License 2.0
33 stars 7 forks source link

feat(wiby result): change result command output and exit codes #74

Closed rodion-arr closed 3 years ago

rodion-arr commented 3 years ago

Following https://github.com/pkgjs/wiby/issues/57#issuecomment-752384850 this PR introduces updates to wiby result command:

{
   "status":"failure",
   "results":[
      {
         "dependent":"wiby-test/partial",
         "status":"pending",
         "runs":[
            ["Travis CI - Branch", null]
         ]
      },
      {
         "dependent":"wiby-test/fail",
         "status":"failure",
         "runs":[
            [ "Travis CI - Branch", "failure" ]
         ]
      },
      {
         "dependent":"wiby-test/pass",
         "status":"pending",
         "runs":[
             [ "Travis CI - Branch", null ]
         ]
      }
   ]
}

Related to #57

ghinks commented 3 years ago

I saw the changes you made in the getOverallStatusForAllRuns, many thanks.

Still reviewing. I took the main branch and merged back into your changes and created scoped package @gvhinks/wiby@0.0.6-development. I then created a PR on a dependency test package. The PR's associated action completed once I typed wiby result.

I took some screen shots of the actions with DEBUG=wiby:*

Screen Shot 2021-01-14 at 5 50 32 PM Screen Shot 2021-01-14 at 5 51 54 PM

from an integration point of view its looking good.

dominykas commented 3 years ago

Looks good, aside from what I assume was a typo?

dominykas commented 3 years ago

:tada: This PR is included in version 0.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: