search

pkgjs / wiby

"Will I break you" - a tool for testing dependents
Apache License 2.0
33 stars 7 forks source link

Upgrade `tap` to v15 #91

Closed rodion-arr closed 3 years ago

rodion-arr commented 3 years ago

We were affected by 2 major changes in tap v15:

  1. Separate tap.has (tap.include()) from tap.match, so these are distinct. It was required to change tap.include() to tap.match() as next code is behaves on v15 like this: 
    tap.test('test 15', async (tap) => {
const string = 'some text expected'
tap.include(string, 'expected') // will fail
tap.match(string, 'expected') // will pass
})
  2. --check-coverage on by default. Tap started to fail by default in case coverage is under 100%. So I added few more tests to be in "100% Coverage Club 🏅"

Related to #89

ghinks commented 3 years ago

I had a bit of trouble getting the tests to pass. Even when I pulled from Rodion's branch there were issues.

rodion-arr commented 3 years ago

For me it was required to update git version due to git init --initial-branch command was failing.

ghinks commented 3 years ago

many thanks @rodion-arr , I'm good again.

dominykas commented 3 years ago

:tada: This PR is included in version 0.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: