Closed ghinks closed 3 years ago
👏 Thanks. sorry for not responding and not clarifying things earlier... I see there's some other discussions on the issue - will check those out now 👍
I'm redoing this with the suggestions that it be a different feature flag. I will incorporate the comments you made above. The tough part is the new feature name
I am going to merge the changes I have made back into this PR now. We may need to re-review it.
🤔 I see you added close-pr
as a new command. I guess it might be useful on its own. 👍
That said, I think we probably still need to add it into wiby clean
as well? Because wiby clean
won't be able to delete branches if they have PRs open.
many thanks for the reviews
I'm keen to merge this, but https://github.com/pkgjs/wiby/pull/93#discussion_r615362448 is not yet resolved? (the parentBranchName
thread)
I'll look at this with respect to #93 tomorrow. Today I need to prep or the talk for OpenJSWorld.
@dominykas I had some extra time so I have addressed the case where the dependency feature branch name could be pre-existing in the dependent repo, and altered the PR raised to be wiby-feature-x into feature-x in that case.
wiby test
(don't really expect ☝️ to work, but still hoping that maybe GH fixed the issue I was having...)
:tada: This PR is included in version 0.8.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
Changes for issue 53
Both opens the draft PR on test and closes it on result
using --pullrequest, open to use of other names
goes in ontop of pull 91 tap update