Handle a couple of edge cases

pkgjs / wiby

"Will I break you" - a tool for testing dependents

Apache License 2.0

33 stars 7 forks source link

Handle a couple of edge cases #94

Closed dominykas closed 3 years ago

dominykas commented 3 years ago

This is mostly to get by brain working to figure out what to do when a target branch already exists.

fixes a wiby result crash when a branch already exists (see #46)
fixes a double-prefix situation when starting point is a branch that's already named wiby-* (see #78)

ghinks commented 3 years ago

I pulled it down locally and ran and verified it. Even against node 16.

The intent to check to see if the branch already exists and then to set the pipeline status enum to MISSING is clear.

This is a general comment, not specific to this PR, our tests are getting complicated and at some point will reach the very difficult to understand stage. For now not an issue, but my counsel is that if this were to become successful and adopted some re-work may be necessary.

dominykas commented 3 years ago

Agreed on the testing bit. The amount of mocks one has to set up when testing things like this is quite annoying... but testing against a real GH API is also not exactly viable, since you end up with failures due to networking flakes, and it's hard to also ensure a clean slate, and then you also can't run many things in parallel...

So yeah, no easy solution. But we'll come up with something eventually, I'm sure.

dominykas commented 3 years ago

:tada: This PR is included in version 0.6.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: