Closed pkgw closed 3 months ago
I closed and reopened this because the CI didn't start up when I first filed the PR, for some reason. It seems to be going now.
Closes #384.
Thanks Peter! rubbl:ndarray passes my tests in Marlu.
not related to this PR but I found that adding .flag("-Wno-deprecated-declarations")
in build.rs gets rid of a lot of compiler spam about sprintf you get when compiling on macOS
Great, thanks for checking.
I'll aim to work on one more PR that addresses some of the warnings you've mentioned, and hopefully also adds CI on a few more platforms, and then I think we'll be ready for a release.
Here we finally fix the warning about uninitialized data in our casatables array buffers. We need to tweak the CasaDataType trait a bit, but no one external should have been implementing it themselves, so that shouldn't be an issue. It took me some time to get the trait specifications right but in the end it's not too complicated.
@d3v-null Would you mind trying out this branch and double-checking that the code seems to be working in your applications? I think that I've got the semantics right, and hopefully the compiler will catch anything problematic, but it certainly wouldn't hurt to do some additional testing here.