search

pkgxdev / homebrew-made

brew install pkgxdev/made/pkgx
Apache License 2.0
29 stars 6 forks source link

Bottles! #2

Closed jhheider closed 1 year ago

jhheider commented 1 year ago

@mxcl @jonchang: other than the, frankly, abusive misuse of run(), does this look sane to you?

proof that it works: https://github.com/teaxyz/homebrew-pkgs/actions/runs/5538089011

credit to GPT-4 for helping while also misleading me, per usual.

the secret sauce is that it repacks the artifacts we already generate on release to use for bottles.

mxcl commented 1 year ago

@jhheider this got forgotten, can we get it working? I want to update install instructions.

mxcl commented 1 year ago

merging as I want this today but would still love to get a @jonchang lookie

jhheider commented 1 year ago

I lol’d at shelling out to mkdir but a minor thing. Approved.

That's hopefully the worst sin included. It's about halfway between typescript and shellscript, and can definitely take some cleanup.

jonchang commented 1 year ago

I missed this but this looks reasonable! As long as the install receipt is handled it should work OK, and tea itself can handle being relocated without brew's help so that is the only other avenue for concern that is addressed.