search

pkgxdev / libpkgx

`import`… but with pkging powers
https://npmjs.com/libpkgx
Apache License 2.0
62 stars 11 forks source link

allow useMoustaches.tokenize.custom(string, string) for custom moustaches #52

Closed jhheider closed 8 months ago

jhheider commented 10 months ago

this would greatly simplify https://github.com/pkgxdev/brewkit/pull/196 which overloads version.raw to allow regexp rewriting in the URLs.

mxcl commented 9 months ago

can you provide the example of why thanks

jhheider commented 9 months ago

yeah... looking back at our exchange in discord, it was about the overloading of version.raw at https://github.com/pkgxdev/brewkit/pull/196/files#diff-4580bd7f95073ce9a8e3d00278a10fe7d2411d1e52d64132691b1a97350e1090R117-R139. that would allow for the definition of a version.rewritten key in that sequence of code that wouldn't necessarily require explicit support in useMoustaches (beyond the generalized case of allowing custom moustache implementations). this means consumers of libpkgx (such as brewkit) could inject their own moustached keys using libpkgx primatives for their specific use-case.

jhheider commented 9 months ago

conversation begins here if you want to slog through it.

mxcl commented 8 months ago

Closing since there are no explicit examples provided.