coveralls
commented
7 months ago Pull Request Test Coverage Report for Build 7732868666
- -71 of 208 (65.87%) changed or added relevant lines in 4 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.8%) to 84.312%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| src/hooks/useSync.ts | 13 | 19 | 68.42% | ||
| src/plumbing/which.ts | 3 | 13 | 23.08% | ||
| src/hooks/usePantry.ts | 19 | 44 | 43.18% | ||
| src/hooks/useSyncCache.ts | 102 | 132 | 77.27% | ||
| <!-- | Total: | 137 | 208 | 65.87% | --> |
| Totals | |
|---|---|
| Change from base Build 7713391169: | 0.8% |
| Covered Lines: | 2497 |
| Relevant Lines: | 2871 |
Note that the sqlite3 deno library downloads its own sqlite. Instead we should:
However there isn’t a way to get it to do that yet. See https://github.com/denodrivers/sqlite3/issues/119
Possibly we could vendor and modify.
Also the cache should “failsafe” and fall back on the pantry in the case of issues with FFI or sqlite or our code.