pkgxdev / pkgx

run anything
https://pkgx.sh
Apache License 2.0
8.95k stars 1.36k forks source link

Adds cdk.json to devenv list #908

Closed dburriss closed 8 months ago

dburriss commented 9 months ago

This addresses #883

If cdk.json exists in the folder, dev will install the AWS CDK CLI.

image
coveralls commented 9 months ago

Pull Request Test Coverage Report for Build 7498681701

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.


Totals Coverage Status
Change from base Build 7422369046: 0.004%
Covered Lines: 1429
Relevant Lines: 1459

💛 - Coveralls
mxcl commented 8 months ago

Thanks for the contribution!

What sort of test should I write for this? I see the tests for this but don't really understand "supplemental fixture" vs "fixed fixture".

Not sure I remember either. Just add a fixture to ./fixtures that you can then add to one of the arrays in the tests for dev and then get coverage up. If the lines are covered we're good.

How would I test this manually? Can I install pkgx from my branch, test it, then flip bach to stable easily?

$ deno task install

Will install your checkout to /usr/local/bin/pkgx, the shellcode will use that.

dburriss commented 8 months ago

@mxcl 1 issue I did run into was that it was still picking up the 1.1.1 version when I ran dev. I just brew uninstalled pkgx and it then used my developer version.

✅ Tests are in and passing. ✅ The manual test worked (see description).

mxcl commented 8 months ago

1 issue I did run into was that it was still picking up the 1.1.1 version when I ran dev. I just brew uninstalled pkgx and it then used my developer version.

Oh ok, I imagine your brew PATH is ahead of /usr/local/bin so yeah, that would happen. I can probs make the deno task install savvy to that so it warns you. Thanks for the heads up