Closed dburriss closed 8 months ago
We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report. To ensure accuracy in future PRs, please see these guidelines. A quick fix for this PR: rebase it; your next report should be accurate.
Totals | |
---|---|
Change from base Build 7422369046: | 0.004% |
Covered Lines: | 1429 |
Relevant Lines: | 1459 |
Thanks for the contribution!
What sort of test should I write for this? I see the tests for this but don't really understand "supplemental fixture" vs "fixed fixture".
Not sure I remember either. Just add a fixture to ./fixtures
that you can then add to one of the arrays in the tests for dev
and then get coverage up. If the lines are covered we're good.
How would I test this manually? Can I install pkgx from my branch, test it, then flip bach to stable easily?
$ deno task install
Will install your checkout to /usr/local/bin/pkgx
, the shellcode will use that.
@mxcl 1 issue I did run into was that it was still picking up the 1.1.1 version when I ran dev
. I just brew uninstalled pkgx and it then used my developer version.
✅ Tests are in and passing. ✅ The manual test worked (see description).
1 issue I did run into was that it was still picking up the 1.1.1 version when I ran dev. I just brew uninstalled pkgx and it then used my developer version.
Oh ok, I imagine your brew PATH is ahead of /usr/local/bin
so yeah, that would happen. I can probs make the deno task install
savvy to that so it warns you. Thanks for the heads up
This addresses #883
If cdk.json exists in the folder,
dev
will install the AWS CDK CLI.