Scrub 'pkicreate'/'pkiremove' entries from source code

[pki-bot]

This issue was migrated from Pagure Issue #3047. Originally filed by mharmsen (@mharmsen) on 2018-08-07 13:44:36:

• Assigned to nobody

---

Since 'pkicreate'/'pkiremove' were replaced long ago by 'pkispawn'/'pkidestroy' respectively, scrub these values from the source code . . .

• CS.cfg (change 'pkicreate' to 'pkispawn') :

  base/tps/shared/conf/CS.cfg:pkicreate.admin_secure_port=[PKI_ADMIN_SECURE_PORT]
  base/tps/shared/conf/CS.cfg:pkicreate.agent_secure_port=[PKI_AGENT_SECURE_PORT]
  base/tps/shared/conf/CS.cfg:pkicreate.ee_secure_port=[PKI_EE_SECURE_PORT]
  base/tps/shared/conf/CS.cfg:pkicreate.group=[PKI_GROUP]
  base/tps/shared/conf/CS.cfg:pkicreate.pki_instance_name=[PKI_INSTANCE_NAME]
  base/tps/shared/conf/CS.cfg:pkicreate.pki_instance_root=[PKI_INSTANCE_ROOT]
  base/tps/shared/conf/CS.cfg:pkicreate.secure_port=[PKI_SECURE_PORT]
  base/tps/shared/conf/CS.cfg:pkicreate.subsystem_type=[PKI_SUBSYSTEM_TYPE]
  base/tps/shared/conf/CS.cfg:pkicreate.systemd.servicename=[PKI_SYSTEMD_SERVICENAME]
  base/tps/shared/conf/CS.cfg:pkicreate.tomcat_server_port=[TOMCAT_SERVER_PORT]
  base/tps/shared/conf/CS.cfg:pkicreate.unsecure_port=[PKI_UNSECURE_PORT]
  base/tps/shared/conf/CS.cfg:pkicreate.user=[PKI_USER]
  base/tks/shared/conf/CS.cfg:pkicreate.pki_instance_root=[PKI_INSTANCE_ROOT]
  base/tks/shared/conf/CS.cfg:pkicreate.pki_instance_name=[PKI_INSTANCE_NAME]
  base/tks/shared/conf/CS.cfg:pkicreate.subsystem_type=[PKI_SUBSYSTEM_TYPE]
  base/tks/shared/conf/CS.cfg:pkicreate.agent_secure_port=[PKI_AGENT_SECURE_PORT]
  base/tks/shared/conf/CS.cfg:pkicreate.ee_secure_port=[PKI_EE_SECURE_PORT]
  base/tks/shared/conf/CS.cfg:pkicreate.admin_secure_port=[PKI_ADMIN_SECURE_PORT]
  base/tks/shared/conf/CS.cfg:pkicreate.secure_port=[PKI_SECURE_PORT]
  base/tks/shared/conf/CS.cfg:pkicreate.unsecure_port=[PKI_UNSECURE_PORT]
  base/tks/shared/conf/CS.cfg:pkicreate.tomcat_server_port=[TOMCAT_SERVER_PORT]
  base/tks/shared/conf/CS.cfg:pkicreate.user=[PKI_USER]
  base/tks/shared/conf/CS.cfg:pkicreate.group=[PKI_GROUP]
  base/tks/shared/conf/CS.cfg:pkicreate.systemd.servicename=[PKI_SYSTEMD_SERVICENAME]
  base/ocsp/shared/conf/CS.cfg:pkicreate.pki_instance_root=[PKI_INSTANCE_ROOT]
  base/ocsp/shared/conf/CS.cfg:pkicreate.pki_instance_name=[PKI_INSTANCE_NAME]
  base/ocsp/shared/conf/CS.cfg:pkicreate.subsystem_type=[PKI_SUBSYSTEM_TYPE]
  base/ocsp/shared/conf/CS.cfg:pkicreate.agent_secure_port=[PKI_AGENT_SECURE_PORT]
  base/ocsp/shared/conf/CS.cfg:pkicreate.ee_secure_port=[PKI_EE_SECURE_PORT]
  base/ocsp/shared/conf/CS.cfg:pkicreate.admin_secure_port=[PKI_ADMIN_SECURE_PORT]
  base/ocsp/shared/conf/CS.cfg:pkicreate.secure_port=[PKI_SECURE_PORT]
  base/ocsp/shared/conf/CS.cfg:pkicreate.unsecure_port=[PKI_UNSECURE_PORT]
  base/ocsp/shared/conf/CS.cfg:pkicreate.tomcat_server_port=[TOMCAT_SERVER_PORT]
  base/ocsp/shared/conf/CS.cfg:pkicreate.user=[PKI_USER]
  base/ocsp/shared/conf/CS.cfg:pkicreate.group=[PKI_GROUP]
  base/ocsp/shared/conf/CS.cfg:pkicreate.systemd.servicename=[PKI_SYSTEMD_SERVICENAME]
  base/ca/shared/conf/CS.cfg:pkicreate.pki_instance_root=[PKI_INSTANCE_ROOT]
  base/ca/shared/conf/CS.cfg:pkicreate.pki_instance_name=[PKI_INSTANCE_NAME]
  base/ca/shared/conf/CS.cfg:pkicreate.subsystem_type=[PKI_SUBSYSTEM_TYPE]
  base/ca/shared/conf/CS.cfg:pkicreate.agent_secure_port=[PKI_AGENT_SECURE_PORT]
  base/ca/shared/conf/CS.cfg:pkicreate.ee_secure_port=[PKI_EE_SECURE_PORT]
  base/ca/shared/conf/CS.cfg:pkicreate.ee_secure_client_auth_port=[PKI_EE_SECURE_CLIENT_AUTH_PORT]
  base/ca/shared/conf/CS.cfg:pkicreate.admin_secure_port=[PKI_ADMIN_SECURE_PORT]
  base/ca/shared/conf/CS.cfg:pkicreate.secure_port=[PKI_SECURE_PORT]
  base/ca/shared/conf/CS.cfg:pkicreate.unsecure_port=[PKI_UNSECURE_PORT]
  base/ca/shared/conf/CS.cfg:pkicreate.tomcat_server_port=[TOMCAT_SERVER_PORT]
  base/ca/shared/conf/CS.cfg:pkicreate.user=[PKI_USER]
  base/ca/shared/conf/CS.cfg:pkicreate.arg11.group=[PKI_GROUP]
  base/ca/shared/conf/CS.cfg:pkicreate.systemd.servicename=[PKI_SYSTEMD_SERVICENAME]
  base/kra/shared/conf/CS.cfg:pkicreate.pki_instance_root=[PKI_INSTANCE_ROOT]
  base/kra/shared/conf/CS.cfg:pkicreate.pki_instance_name=[PKI_INSTANCE_NAME]
  base/kra/shared/conf/CS.cfg:pkicreate.subsystem_type=[PKI_SUBSYSTEM_TYPE]
  base/kra/shared/conf/CS.cfg:pkicreate.agent_secure_port=[PKI_AGENT_SECURE_PORT]
  base/kra/shared/conf/CS.cfg:pkicreate.ee_secure_port=[PKI_EE_SECURE_PORT]
  base/kra/shared/conf/CS.cfg:pkicreate.admin_secure_port=[PKI_ADMIN_SECURE_PORT]
  base/kra/shared/conf/CS.cfg:pkicreate.secure_port=[PKI_SECURE_PORT]
  base/kra/shared/conf/CS.cfg:pkicreate.unsecure_port=[PKI_UNSECURE_PORT]
  base/kra/shared/conf/CS.cfg:pkicreate.tomcat_server_port=[TOMCAT_SERVER_PORT]
  base/kra/shared/conf/CS.cfg:pkicreate.user=[PKI_USER]
  base/kra/shared/conf/CS.cfg:pkicreate.group=[PKI_GROUP]
  base/kra/shared/conf/CS.cfg:pkicreate.systemd.servicename=[PKI_SYSTEMD_SERVICENAME]
  base/tps-client/doc/CS.cfg:pkicreate.pki_instance_root=[PKI_INSTANCE_ROOT]
  base/tps-client/doc/CS.cfg:pkicreate.pki_instance_name=[PKI_INSTANCE_NAME]
  base/tps-client/doc/CS.cfg:pkicreate.subsystem_type=[PKI_SUBSYSTEM_TYPE]
  base/tps-client/doc/CS.cfg:pkicreate.secure_port=[PKI_SECURE_PORT]
  base/tps-client/doc/CS.cfg:pkicreate.non_clientauth_secure_port=[NON_CLIENTAUTH_SECURE_PORT]
  base/tps-client/doc/CS.cfg:pkicreate.unsecure_port=[PKI_UNSECURE_PORT]
  base/tps-client/doc/CS.cfg:pkicreate.user=[PKI_USER]
  base/tps-client/doc/CS.cfg:pkicreate.group=[PKI_GROUP]

• CS.cfg (change 'pkiremove' to 'pkidestroy') :

  base/tps/shared/conf/CS.cfg:pkiremove.cert.subsystem.nickname=subsystemCert cert-[PKI_INSTANCE_NAME]
  base/tks/shared/conf/CS.cfg:pkiremove.cert.subsystem.nickname=subsystemCert cert-[PKI_INSTANCE_NAME]
  base/ocsp/shared/conf/CS.cfg:pkiremove.cert.subsystem.nickname=subsystemCert cert-[PKI_INSTANCE_NAME]
  base/ca/shared/conf/CS.cfg:pkiremove.cert.subsystem.nickname=subsystemCert cert-[PKI_INSTANCE_NAME]
  base/kra/shared/conf/CS.cfg:pkiremove.cert.subsystem.nickname=subsystemCert cert-[PKI_INSTANCE_NAME]
  base/tps-client/doc/CS.cfg:pkiremove.cert.subsystem.nickname=subsystemCert cert-[PKI_INSTANCE_NAME]

• Code (change '/usr/bin/pkicreate' to '/usr/sbin/pkispawn') :

  base/server/share/webapps/pki/admin/console/config/donepanel.vm:To create additional instances, type "/usr/bin/pkicreate" on the command line.
  base/tps-client/apache/docroot/tps/admin/console/config/donepanel.vm:To create additional instances, type "/usr/bin/pkicreate" on the command line.

• Code (change 'pkicreate' to 'pkispawn') :

  base/server/python/pki/server/deployment/pkihelper.py:            kraport = cs_cfg.get('pkicreate.secure_port')
  base/server/python/pki/server/deployment/pkihelper.py:            tpsport = cs_cfg.get('pkicreate.secure_port')
  base/server/python/pki/server/deployment/pkihelper.py:        adminsport = cs_cfg.get('pkicreate.admin_secure_port', '')
  base/server/python/pki/server/deployment/pkihelper.py:        agentsport = cs_cfg.get('pkicreate.agent_secure_port', '')

• Code (change 'pkiremove' to 'pkidestroy') :

  base/tps-client/lib/perl/PKI/TPS/SecurityDomainPanel.pm:    # Add values necessary for 'pkiremove' . . .
  base/tps-client/lib/perl/PKI/TPS/DisplayCertChainPanel.pm:            # Store additional values necessary for 'pkiremove' . . .
  base/tps-client/lib/perl/PKI/TPS/DonePanel.pm:    # add service.securityDomainPort to the config file in case pkiremove
  scripts/remove_pki_components:printf "           use the 'pkiremove' utility to remove INDIVIDUAL\n"
  scripts/remove_pki_components:printf "           may be located anywhere.  Please use the 'pkiremove'\n"

• Remove the following scripts as they are contained in branches for legacy product versions:

  base/scripts/enable_cvs_keywords_in_svn
  scripts/install_default_pki_instances
  scripts/install_default_ca_instance
  scripts/remove_default_pki_instances

• Update all documentation to reflect these changes (e.g. - Administration Guide).

• Create Upgrade scripts to account for these changes (specifically installed 'CS.cfg' files).

[pki-bot]

Comment from mharmsen (@mharmsen) at 2018-08-07 13:47:47

The following legacy ticket was closed as a duplicate of this more comprehensive ticket:

• https://pagure.io/dogtagpki/issue/222

[pki-bot]

Comment from mharmsen (@mharmsen) at 2018-08-07 13:47:48

Metadata Update from @mharmsen:

• Custom field component adjusted to None
• Custom field feature adjusted to None
• Custom field origin adjusted to None
• Custom field proposedmilestone adjusted to None
• Custom field proposedpriority adjusted to None
• Custom field reviewer adjusted to None
• Custom field type adjusted to None
• Custom field version adjusted to None