search

pki-io / admin

Other
15 stars 7 forks source link

Make use of mow.cli interceptors to init and close loggers #146

Closed jawher closed 9 years ago

jawher commented 9 years ago

mow.cli added support for before and after interceptors (see jawher/mow.cli#12 and jawher/mow.cli#15), which are a perfect match for what every command in pkt.io/admin was doing, mainly initialising a logger and closing it afterwards.

The relevant section on interceptors in mow.cli's README file

Note however that this won't build until pki-io's fork of mow.cli is updated to at least 5a708d497f63791effeb817ab7501e6aa80f74af, or to the current HEAD of master as is done in the Vendors file.

Review on Reviewable

zeroXten commented 9 years ago

Updated the SupplyChain file in the build repo to include mow.cli and ran supplychain.sh, so now the pki.io fork is up to date. Test is now passing, so merging into development. Thanks for the amazing PR :)