Closed aThorp96 closed 5 years ago
pkill37
commented
5 years ago Thanks for contributing Andrew!
Checking if the binary exists before installing is a good idea. However is it guaranteed that the formula name is the same as the binary name? And why separate the formulas into linuxify_installs and linuxify_updates?
Also please check the syntax errors, you should end if-statements with fi.
aThorp96
commented
5 years ago @fabiomaia I separated the groups because when I first ran the script, I noticed some brew install requests would cause it to crash. I correlated this bug with installing a a few utilities that aren't on MacOS by default, but I already had installed on my system. In contrast the utilities that are on MacOS already and are just getting replaced / updated had no problem overwriting their existing versions. My solution was to separate the two groups. I also added gcc to the list, since I found my copy to not compile everything on the list. This was while running High Sierra. As for the syntax error, I'm sorry about that. My remote was out of date 🤦♂️
aThorp96
commented
5 years ago It's not guaranteed that the binary name and install names are the same. One I just saw was file-formulas. This could be a problem. It's not causing any harm right now, but obviously that could change with the addition of formulas. I will definitely look into this.
When I attempted to run the script, it crashed. I had several of the utils already installed and brew didn't like calling install on something that was already installed. Because of this I separated packages that need to be freshly installed vs the ones that need to be updated. If the program needs to be installed already has been, it doesn't install the program (line 71).