pkill37 / linuxify

🍏🐧 Transparently transform the macOS CLI into a fresh GNU/Linux CLI experience.
MIT License
888 stars 69 forks source link

macOS Catalina #23

Closed pnodet closed 4 years ago

pnodet commented 4 years ago

Has of Catalina, zsh is now the default shell instead of bash.

However using linuxify switches back to bash, maybe it could be on option rather than being automatic ?

pnodet commented 4 years ago

Those lines:

Change default shell to brew-installed /usr/local/bin/bash

grep -qF '/usr/local/bin/bash' /etc/shells || echo '/usr/local/bin/bash' | sudo tee -a /etc/shells > /dev/null
chsh -s /usr/local/bin/bash
pkill37 commented 4 years ago

Thanks for letting me know this! I'm not currently running macOS, so I was unaware. I'll probably go back to macOS next week though, so I'll take another look.

I think I'll just up the requirements to Catalina and assume zsh.

ghost commented 4 years ago

facing same issue, thanks for your job

curusarn commented 4 years ago

Maybe it would be best to detect which shell is set as login and honor the setting automatically. What do you think?

pkill37 commented 4 years ago

I just merged the fix by @stephanGarland which should fix this :)