search

pkiraly / qa-catalogue-datavis

Data visualisations for library union catalogues
GNU General Public License v3.0
0 stars 0 forks source link

Improve the container layout #18

Open pkiraly opened 9 months ago

pkiraly commented 9 months ago

When we change between tabs, we have to add an extra trick in JS:

d3.select(containers[i]).style("visibility", "visible");
let defaultDisplay = container == '#map-container' ? 'flex' : 'display';
d3.select(containers[i]).style("display", defaultDisplay);

If the containers' display is flex, the cataloging timeline container's second timeline is displayed near the first timeline, and not below. If the map container!s display is block then the table is not near, but below the map. Right now this trick solves the issue, but it is not nice and maintainable when we will have much more tabs. I prefer a solution which does not need maintaining exceptions.