Handle communication with Solr in a single place

pkiraly / qa-catalogue-web

QA Catalogue / A data quality dashboard for MARC catalogues

GNU General Public License v3.0

10 stars 6 forks source link

Handle communication with Solr in a single place #137

Open pkiraly opened 1 year ago

nichtich commented 1 year ago

Left to do:

searchFacets in classes/Collocations.php
getRecordIdByErrorId in classes/Data.php

I stumbled upon these because the query silently resulted in 404 but no error was thrown, so it resulted in a timeout instead.

pkiraly commented 1 year ago

The second one is already fixed some days ago by eb4077d316e7fc794a753681dcd6a844f4d414cd. Do you still have the issue? If yes: what is the URL that triggers it?

nichtich commented 1 year ago

It's triggered via https://github.com/pkiraly/qa-catalogue-web/blob/develop/classes/Data.php#L448-L450 by an additional / between endpoint and core. In general file_get_contents should not be called with an URL expect for inside class Solr.