Changing needed after incorporating the dashboard

pkiraly / qa-catalogue-web

QA Catalogue / A data quality dashboard for MARC catalogues

GNU General Public License v3.0

10 stars 6 forks source link

Changing needed after incorporating the dashboard #140

Open pkiraly opened 10 months ago

pkiraly commented 10 months ago

After @NelDav has created the dashboard, some changes might be necessary, such as

[ ] update the README with the new default for the default-tab configuration
[ ] thinking whether the dashboard needs a menu element
[ ] minor modifications for the dashboard itself

nichtich commented 10 months ago

Just two thoughts:

The default-tab, if not configured, should not be start but about
The class Start should be renamed to Dashboard

pkiraly commented 10 months ago

I agree with the second suggestion. I am not sure about the about as starting page, I would expect a page which displays some result instead: validation or completeness. I am also thinking if

the dashboard should be added to the menu
which position? at the beginning? before about?

Independent, but if we change the menu order: validation should be placed before completeness