Issues status graphic does not work with zero issues

pkiraly / qa-catalogue-web

QA Catalogue / A data quality dashboard for MARC catalogues

GNU General Public License v3.0

10 stars 6 forks source link

Issues status graphic does not work with zero issues #183

Open TobiasNx opened 4 months ago

TobiasNx commented 4 months ago

with the following content in issue-total.csv

type,instances,records
0,0,81104

Also see here: https://test-qa-catalogue.lobid.org/qa-catalogue/?tab=issues&lang=en

pkiraly commented 4 months ago

@TobiasNx In order to debug this issue, I would like to reproduce it. Is it possible to download a sample of your records from somewhere? If there is no publicly available records, could you send me a sample? (my email address is pkiraly at gwdg.de)

TobiasNx commented 4 months ago

This is the file we use:

oersiToMarc.mrc.xml.gz

pkiraly commented 4 months ago

@TobiasNx Thanks! I was able to reproduce it and debug it. You are right, this means that the tool did not detect any kinds of errors in this data set. I will make a fix later.

pkiraly commented 4 months ago

@TobiasNx I merged the solution to the main branch, and I have recreated the docker image as well. If you remove your current container and image, and recreate them again from ghcr.io/pkiraly/qa-catalogue:main, it should work. Could you please report the result here?